Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default to each parameters #609

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

BastLeblanc
Copy link
Contributor

Issue #603

Description of changes:
added empty default values for all parameters which didn't have any default

Default: ''

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):

  • one deployment
  • tested the script ./scripts/deploy-cloudformation-stacks.sh

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@BastLeblanc BastLeblanc requested a review from gfaires July 8, 2024 20:52
Copy link
Contributor

@gfaires gfaires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfaires gfaires merged commit 8ca08dc into aws-samples:master Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

2 participants