change trace exporter trasnport protocol from grpc to http/protobuf #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
reviewed
Jan 27, 2024
| @@ -2,7 +2,8 @@ | |||
| "OTEL_SMP_ENABLED": "true", | |||
| "OTEL_TRACES_SAMPLER_ARG": "endpoint=http://cloudwatch-agent.amazon-cloudwatch:2000", | |||
| "OTEL_TRACES_SAMPLER": "xray", | |||
| "OTEL_EXPORTER_OTLP_TRACES_ENDPOINT": "http://cloudwatch-agent.amazon-cloudwatch:4315", | |||
| "OTEL_EXPORTER_OTLP_PROTOCOL": "http/protobuf", | |||
| "OTEL_EXPORTER_OTLP_TRACES_ENDPOINT": "http://cloudwatch-agent.amazon-cloudwatch:4316/v1/traces", | |||
There was a problem hiding this comment.
Q: have we tested this endpoint http://cloudwatch-agent.amazon-cloudwatch:4316/v1/traces with traces in the current CWAgent?
There was a problem hiding this comment.
From OTel doc, http url v1/traces is for tracs, v1/metrics for metrics and v1/logs for logs.
I verified the Agent http traces endpoint in local by settingOTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://localhost:4316/v1/traces, but haven't verified in operator.
OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://localhost:4316/v1/traces OTEL_METRICS_EXPORTER=none OTEL_SMP_ENABLED=true OTEL_AWS_SMP_EXPORTER_ENDPOINT=http://localhost:4315 java -javaagent:/Users/wangzl/workspace/appsig/aws-otel-java-instrumentation/otelagent/build/libs/aws-opentelemetry-agent-1.32.0-SNAPSHOT.jar -jar ./build/libs/spring-boot-0.0.1-SNAPSHOT.jar Application
There was a problem hiding this comment.
Thanks! I think the local verification should be sufficient.
thpierce
reviewed
Jan 29, 2024
sky333999
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Trace otlp exporter in java EKS operator is
grpc, does not follow OTel specification recommendationhttp/protobufDescription of changes:
Change TraceOtlpExporter protocol from
grpctohttp/protobufBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.