Update SMP config names to AppSignals with backward compatibility #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
approved these changes
Feb 9, 2024
lisguo
approved these changes
Feb 13, 2024
mitali-salvi
approved these changes
Feb 13, 2024
srprash
added a commit
to aws-observability/aws-otel-python-instrumentation
that referenced
this pull request
Feb 15, 2024
We are renaming the SMP configs: `OTEL_SMP_ENABLED` -> `OTEL_AWS_APP_SIGNALS_ENABLED` `OTEL_AWS_SMP_EXPORTER_ENDPOINT` -> `OTEL_AWS_APP_SIGNALS_EXPORTER_ENDPOINT` Related PRs: aws-observability/aws-otel-java-instrumentation#744 aws/amazon-cloudwatch-agent-operator#84 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
We are changing SMP to AppSIgnals. See related PR on ADOT Java: aws-observability/aws-otel-java-instrumentation#744
Description of changes:
Note: Once we are sure that all users are upgraded to new version of ADOT Java, the SMP configs should be removed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.