Fixing EKS and performanceTracking Integration Tests #370
Conversation
…integration--failure-test
|
Nit: The title of the PR can be named better |
|
The performance test looks good but can you double check the dynamo database to see if it saved the test correctly (maybe a screenshot). Does this also work for traces? |
|
Please rename the title of the PR. It is not descriptive enough. Also provide more details for |
generator/test_case_generator.go
Outdated
| @@ -80,8 +80,8 @@ var testTypeToTestConfig = map[string][]testConfig{ | |||
| testDir: "./test/acceptance", | |||
| targets: map[string]map[string]struct{}{"os": {"ubuntu-20.04": {}}}, | |||
| }, | |||
| // skipping FIPS test as the test cannot be verified | |||
| // neither ssh nor SSM works after a reboot once FIPS is enabled | |||
| //skipping FIPS test as the test cannot be verified | |||
There was a problem hiding this comment.
nit: likely your formatters but we don't need these changes
| ] | ||
| } | ||
| POLICY | ||
| assume_role_policy = jsonencode({ |
There was a problem hiding this comment.
Description of the PR isn't clear so can you explain what was the reasons for this change
terraform/performance/main.tf
Outdated
| "cp -r amazon-cloudwatch-agent-test/test/xray/resources /home/ec2-user/", | ||
| "export AWS_REGION=${var.region}", | ||
| "cd ./validator/validators", | ||
| "ls -lirt", |
There was a problem hiding this comment.
nit: Do we need ls -lirt and pwd command here?
| @@ -129,6 +129,7 @@ func (suite *MetricBenchmarkTestSuite) TestAllInSuite() { | |||
| case computetype.EKS: | |||
| log.Println("Environment compute type is EKS") | |||
| for _, testRunner := range getEksTestRunners(env) { | |||
| fmt.Println("testRunner---------", testRunner.Env) | |||
There was a problem hiding this comment.
nit: Is this print line needed?
bhanuba
changed the title
Description of the issue
Found out that few integration tests were failing. These tests used to be running successfully previously.
-EKS Integration
-performanceTrackingtest
Description of changes
-Changed from heredoc syntax (<<POLICY) to jsonencode for fixing the EKS Integration test.
-The validators path was changed but not redirected in main.tf. Fixed by redirecting to the correct path.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Fix for EKS integration test: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/6673973151
Fix for performanceTrackingtest : https://github.com/aws/amazon-cloudwatch-agent/actions/runs/6648952606