Add integ tests for EKS windows #387
Conversation
1. Added terraform templates for fluentbit and CW agent on windows. 2. Fix fluentbit tests for Windows
|
|
||
| variable "k8s_version" { | ||
| type = string | ||
| default = "1.24" |
There was a problem hiding this comment.
is 1.24 intentional? Like is it valuable to test the oldest supported EKS release?
1.24 looks like it is EOL other than extended support - https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
There was a problem hiding this comment.
This version is default is in our integ tests, GHA specifies the actual version that should be used for tests. 1.24 is default version for other terraform templates as well.
KlwntSingh
dismissed stale reviews from mitali-salvi and chadpatel
via
78c6d0d
1. Add CW agent repo arg to terraform
KlwntSingh
force-pushed
the
main-addIntegTests
branch
from
ac859d9 to
0b9a30d
Compare
| testDir: "./test/metric_value_benchmark", | ||
| terraformDir: "terraform/eks/daemon/windows/2022", | ||
| targets: map[string]map[string]struct{}{"arc": {"amd64": {}}}, | ||
| }, | ||
| { |
There was a problem hiding this comment.
Can you check if /test/emf is testing any specific feature and implement it for windows?
There was a problem hiding this comment.
Hi @nathalapooja,
these emf test are testing emf receiver/exporter in CW agent.
Since CI tests are indirectly testing emf already, this particular test can be skipped for Windows at the moment but it is still good to have this test for Windows.
I will work on adding this test for Windows as post-release activity.
Description of changes
License
Tests
Link to Integ tests results for both Linux and Windows. CW agent runs successfully on Both Linux and Windows. Fluenbit fails due to timeout issue when destroying the cluster. There is no issue in functional working of fluentbit.
https://github.com/aws/private-amazon-cloudwatch-agent-staging/actions/runs/8175470234/job/22352686273