Changing data type of appsignals integ test #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okankoAMZ
reviewed
Apr 9, 2024
okankoAMZ
reviewed
Apr 9, 2024
okankoAMZ
reviewed
Apr 9, 2024
|
Is this being used in one of the integration tests? If so can you add the test run so we know it's working |
|
Let's run the integ test a few times and see if the apm team is still affected by this. We should probably ping Mahad to take a look at this as well |
okankoAMZ
approved these changes
Apr 16, 2024
Paramadon
changed the title
jefchien
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Current server_consumer.json and client_producer.json generates invalid app signal metrics. The metrics Latency, Error, and Fault should be an object but instead the request sent to the agent generated the metrics to just be zero.
Metrics are not objects
Description of changes
It is a really small change, the data type of each metric is sum but instead it should be the type exponential_histogram. This is the correct type and it generates correct app signal metrics.
Verifying correct metrics were generated
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Sent json's to the agent and checked the console which had the correct format of the metrics.