Extend CloudWatch Agent AppSignals EC2 tests for MacOS and Window #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making sure we are in the right test repo Finished App Signal EC2 test for mac and windows
Paramadon
changed the title
Paramadon
changed the title
okankoAMZ
reviewed
Apr 24, 2024
| func SendAppTraceMetrics(duration time.Duration) error { | ||
| baseDir := getBaseDir() | ||
|
|
||
| for i := 0; i < int(duration/(5*time.Second)); i++ { |
There was a problem hiding this comment.
For this I think using TimeTicker would be easier to maintain and will be less flakey. Here is an example from traces-test
|
Can you also |
movence
reviewed
Apr 24, 2024
movence
reviewed
Apr 29, 2024
movence
approved these changes
Apr 30, 2024
musa-asad
approved these changes
Apr 30, 2024
okankoAMZ
approved these changes
Apr 30, 2024
| func SendAppTraceMetrics(duration time.Duration) error { | ||
| baseDir := getBaseDir() | ||
|
|
||
| for i := 0; i < int(duration/(5*time.Second)); i++ { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Extending Linux App signal EC2 Test to work on MacOs and Windows.
Description of changes
Changing the validator, which is what MacOs and Winows use for their testing, to have a test for app signals. Both App Signals and Traces are being tested.
Running Integration test
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/8820034431/job/24213490204
Why are some test failing?
If you look at the logs of the test, the validator is passing, those are different issues not correlated with this pr.
Steps taken for testing
Additional change needed to be made
Corrected the json files to generate AppSignals metrics so that App Signal metrics are being generated properly
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.