Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when metrics not yet ready in a cluster #408

Merged
merged 1 commit into from
May 21, 2024

Conversation

movence
Copy link
Contributor

@movence movence commented May 13, 2024

Description of the issue

Container Insights integration test fails with a panic when a cluster is not ready with target metrics

Description of changes

  • Add a precheck before calling rand.Intn

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@movence movence requested a review from a team as a code owner May 13, 2024 18:26
Copy link
Contributor

@Paramadon Paramadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! Preventing to panic during failure bc of the randIdx

@movence movence merged commit 4045108 into aws:main May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants