Disable application signals testing in favor of end-to-end tests #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
reviewed
May 21, 2024
| @@ -211,9 +207,6 @@ var testTypeToTestConfig = map[string][]testConfig{ | |||
| targets: map[string]map[string]struct{}{"arc": {"amd64": {}}}, | |||
| }, | |||
| {testDir: "./test/fluent", terraformDir: "terraform/eks/daemon/fluent/bit"}, | |||
| {testDir: "./test/app_signals", terraformDir: "terraform/eks/daemon/app_signals", | |||
There was a problem hiding this comment.
I imagine there is a bunch of associated code as well to generate telemetry etc.. do we plan on removing all of that as well?
There was a problem hiding this comment.
Yes, this PR is to just disable it at least as a first step to unblock the release.
There is quite a bit of code for appsignals which is mixed in with our ec2 tests as well, so will have a separate pr for it.
There was a problem hiding this comment.
I changed the wording to "disable" instead of "remove"
lisguo
changed the title
mitali-salvi
approved these changes
May 21, 2024
sky333999
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The tests covered in this test repo are also covered in the end-to-end tests: https://github.com/aws/amazon-cloudwatch-agent/blob/main/.github/workflows/application-signals-java-e2e-ec2-asg-test.yml
These tests are more robust, as they use the adot sdks to send elemetry to the agent. The tests in this repo are also stale as a result of the schema changes introduced in aws/amazon-cloudwatch-agent@4193fa1
Description of changes
This PR disables testing for application signals. These tests are wasting resources to test features covered in the workflow linked above.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
N/A