Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding EKS-Addon Gpu test #411
Adding EKS-Addon Gpu test #411
Changes from all commits
53ffe75
8523e45
3dcc4ca
7d84ad6
1c366e6
3dbcb3a
8c30284
ad3663d
031d072
b97c68c
f8514ed
e9ae147
db72428
a3dcc91
b35c91e
747b439
7dd0669
399ede3
f4f64fe
0ae4f56
c8c5fea
e0c5902
ba229fa
b07a1a6
4469748
7d8b9db
f785e3f
09f98ba
ddc61ec
78bf10e
133aca1
ee46157
07e2141
28ea49e
2a28a1c
4fbdf0d
a1eec84
05ce023
b4c57ec
7e31f9b
3951058
ac98069
92a6217
6fb6a51
89d58e2
3889710
b2b5490
c8aac72
5855c50
db41f67
dee4d19
29288f8
dd4ee55
e76ae00
5ad174f
74844bd
63de98d
82c2b9e
d4440eb
13ac63d
cbbab97
234bc29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't using the current build of the agent image, so currently, it's more like a canary test instead of an integration test.
The other eks tests use the agent from the provided repo/tag https://github.com/aws/amazon-cloudwatch-agent-test/blob/main/terraform/eks/daemon/main.tf#L201. This needs to do that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change I replace CWA image to the current build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this being done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 10? I'm curious how long each iteration will take. If there is an issue with a new build or something, this test will delay integ test execution time. should the test itself iterate for x times (probably <10) with some sleep in between?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reduce it to 5, but the terraform has a timeout of 1 hour already and since each test takes around 3 minutes this will add up to 30 minutes +10/15 minutes for terraform. So its about 5 mintues less than the timeout time. I think 10 is fine