Add JMX Metrics #1024
Closed
Add JMX Metrics #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
+ Coverage 57.58% 63.34% +5.76%
==========================================
Files 370 366 -4
Lines 17548 18919 +1371
==========================================
+ Hits 10105 11985 +1880
+ Misses 6848 6313 -535
- Partials 595 621 +26 ☔ View full report in Codecov by Sentry. |
Add Auth Information To JMX Add Default JMX Targets` Add opentelemetry-jmx-metrics.jar To Deb, Darwin Zip, Windows, Zip Add Test Repo Branch When Building MSI
sethAmazon
force-pushed
the
feature-jmx-metrics-b
branch
from
cc7189e to
108db0f
Compare
sethAmazon
commented
Jan 30, 2024
| @@ -224,9 +226,65 @@ func TranslateJsonMapToYamlConfig(jsonConfigValue interface{}) (interface{}, err | |||
| if err = conf.Marshal(cfg); err != nil { | |||
| return nil, err | |||
| } | |||
| return conf.ToStringMap(), nil | |||
| strMap := conf.ToStringMap() | |||
There was a problem hiding this comment.
This is all copied from [REDACTED]
sethAmazon
commented
Jan 30, 2024
| func RemoveTLSRedacted(stringMap map[string]interface{}) { | ||
| type Node struct { | ||
| isTLSParent bool | ||
| isJMXParent bool |
sethAmazon
commented
Jan 30, 2024
| "github.com/aws/amazon-cloudwatch-agent/translator/translate/otel/receiver/jmx" | ||
| ) | ||
|
|
||
| func NewTranslators(conf *confmap.Conf, os string) (pipeline.TranslatorMap, error) { |
There was a problem hiding this comment.
This is copied from [REDACTED]
sethAmazon
commented
Jan 30, 2024
| @@ -51,32 +49,16 @@ func Translate(jsonConfig interface{}, os string) (*otelcol.Config, error) { | |||
| log.Printf("W! CSM has already been deprecated") | |||
| } | |||
|
|
|||
| adapterReceivers, err := adapter.FindReceiversInConfig(conf, os) | |||
| translators, err := host.NewTranslators(conf, os) | |||
There was a problem hiding this comment.
This is copied from [REDACTED]
|
This PR was marked stale due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Auth Information To JMX
Add Default JMX Targets`
Add opentelemetry-jmx-metrics.jar To Deb, Darwin Zip, Windows, Zip
Description of the issue
CloudWatch agent does not support jmx
Description of changes
Add support for jmx
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
aws/amazon-cloudwatch-agent-test#385
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint