Unblock China region integration tests #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dricross
reviewed
Feb 24, 2025
musa-asad
reviewed
Feb 27, 2025
musa-asad
reviewed
Feb 27, 2025
musa-asad
reviewed
Feb 27, 2025
musa-asad
previously approved these changes
Feb 27, 2025
jefchien
reviewed
Feb 27, 2025
jefchien
reviewed
Feb 28, 2025
|
New integration test run: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/13595857669/job/38012754850 |
jefchien
approved these changes
Mar 3, 2025
jefchien
reviewed
Mar 3, 2025
musa-asad
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The EC2LinuxCN tests are not able to start up properly due to errors while fetching dependencies. This creates a gap in our testing for this region.
Description of changes
This change adds a new step to our integration test workflow that zips and uploads the test repo and the necessary dependencies (using
go mod vendor) to an S3 bucket in the China region. Our tests then pull from this S3 bucket instead of attempting to download them directly for each test.This PR is in conjunction with: aws/amazon-cloudwatch-agent-test#469
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. ✅
Tests
Integration test run: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/13595857669
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-sh✅make lint✅