-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support LocalExecutor #138
Merged
Merged
+37
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kytha
requested changes
Sep 4, 2024
Kytha
requested changes
Sep 11, 2024
Kytha
reviewed
Sep 13, 2024
dhegberg
reviewed
Sep 13, 2024
Kytha
reviewed
Sep 17, 2024
Kytha
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other then nitpick, lgtm
dhegberg
approved these changes
Sep 17, 2024
kuyperse
approved these changes
Sep 17, 2024
michaelfu1029
added a commit
that referenced
this pull request
Sep 19, 2024
*Issue #, if available:* Same changes as #138 *Description of changes:* Applied the changes in the PR above to the 2.10.1 images By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. Co-authored-by: Michael Fu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MWAA__SQS__CREATE_QUEUE
is set to false. If we're not creating an SQS queue/using Celery, then we don't want to attempt to create the CeleryExecutor. This is useful for environments where a discrete worker is not necessary/too expensive.MWAA__CORE__DISABLE_CORS
(default false), which, when set to true, sets all CORS-related headers to accept all connections. This is required to make MWAA work in embedded environments (i.e. within a portal or webpage)