Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support LocalExecutor #138

Merged
merged 4 commits into from
Sep 17, 2024
Merged

feat: support LocalExecutor #138

merged 4 commits into from
Sep 17, 2024

Conversation

agupta01
Copy link
Contributor

@agupta01 agupta01 commented Sep 4, 2024

  1. Adds support for LocalExecutor when MWAA__SQS__CREATE_QUEUE is set to false. If we're not creating an SQS queue/using Celery, then we don't want to attempt to create the CeleryExecutor. This is useful for environments where a discrete worker is not necessary/too expensive.
  2. Adds a config variable MWAA__CORE__DISABLE_CORS (default false), which, when set to true, sets all CORS-related headers to accept all connections. This is required to make MWAA work in embedded environments (i.e. within a portal or webpage)

images/airflow/2.9.2/python/mwaa/config/airflow.py Outdated Show resolved Hide resolved
images/airflow/2.9.2/python/mwaa/config/airflow.py Outdated Show resolved Hide resolved
@agupta01 agupta01 requested review from dhegberg and Kytha September 5, 2024 16:58
@agupta01 agupta01 changed the title feat: support LocalExecutor + no-CORS mode feat: support LocalExecutor Sep 12, 2024
@agupta01 agupta01 requested a review from Kytha September 12, 2024 17:56
@agupta01 agupta01 requested review from dhegberg and Kytha September 16, 2024 23:47
Copy link
Contributor

@Kytha Kytha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then nitpick, lgtm

@dhegberg dhegberg merged commit faedb17 into aws:main Sep 17, 2024
1 check passed
michaelfu1029 added a commit that referenced this pull request Sep 19, 2024
*Issue #, if available:*
Same changes as
#138
*Description of changes:*
Applied the changes in the PR above to the 2.10.1 images

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

Co-authored-by: Michael Fu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants