Adding fix for incorrect log level bug and refactoring entrypoint.py to fix circular dependency issue #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhegberg
reviewed
Feb 7, 2025
mayushko26
reviewed
Feb 7, 2025
Kytha
requested changes
Feb 11, 2025
… to fix circular dependency issue
Signed-off-by: Vraj2725 <[email protected]>
Vraj2725
changed the title
|
I implemented changes as per Kyle's suggestions. Have updated he description for the same. |
Kytha
previously approved these changes
Feb 24, 2025
Kytha
approved these changes
Feb 25, 2025
kashyapkannan
approved these changes
Feb 26, 2025
Vraj2725
changed the title
Vraj2725
pushed a commit
to Vraj2725/amazon-mwaa-docker-images
that referenced
this pull request
Mar 3, 2025
Vraj2725
added a commit
that referenced
this pull request
Mar 3, 2025
… fix circular dependency issue (#215)" (#225) … fix circular dependency issue (#215)" This reverts commit f9427c4. *Issue #, if available:* *Description of changes:* - Reverting this commit because this changes break when we export customer environment variables in start-up scripts. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. Co-authored-by: Vraj Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When using airflow versions 2.9.2 and above customer are unable to see error logs when they set their loglevel to
WARNINGor above. The root cause is that in subprocess.py, the lineself.process_logger.info(line.decode("utf-8"))overrides the log level coming from airflow stream to INFO in subprocess.py.Description of changes:
DEBUGto emit all logs and setting root logger to customer's log level to respect customer's log level.entrypoint.pyand breaking down its logic into different files so all files have single responsibility such as:user_requirements.py: Installing user requirements.execute_command.py: Logic for executing all the subprocessessetup_environment.py: Running the startup script and setting up environment variablesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.