Graceful updates metrics #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graceful updates has introduced new logic and edge cases to the image code. This change adds new metrics to be emitted for those edge cases by the task monitor.
dhegberg
reviewed
Feb 21, 2025
…ndling is enabled If signal handling is not enabled, then unexpected_interrupted_tasks_at_shutdown will take the value of interrupted_tasks_at_shutdown which can be non-zero for legitimate use case. This will pollute the metric making it non-reliable for alarming.
dhegberg
approved these changes
Feb 27, 2025
anrajago
approved these changes
Feb 28, 2025
Mercury2699
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Graceful updates has introduced new logic and edge cases to the image code. This change adds new metrics to be emitted for those edge cases by the task monitor.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.