Skip to content

Commit

Permalink
Fix Taco Signing (#255)
Browse files Browse the repository at this point in the history
* testing signing

* update taco CI

* signing confirmed, reverting
  • Loading branch information
xiazcy authored Mar 1, 2024
1 parent c5e9846 commit 4a7d829
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:

- name: Verify TACO filename
run: |
if [ ! -f "tableau-connector/target/neptune-jdbc-${{env.version}}.taco" ]
if [ ! -f "tableau-connector/target/neptune-jdbc-v${{env.version}}.taco" ]
then
echo "Error: The TACO file is either incorrectly named or missing from tableau-connector/target/."
echo "Contents of tableau-connector/target/:"
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
sudo apt-get install jq
# Upload unsigned .taco to S3 Bucket
echo "Obtaining version id and uploading unsigned .taco to S3 Bucket"
version_id=$( aws s3api put-object --bucket ${{ secrets.AWS_UNSIGNED_BUCKET }} --key ${{ secrets.AWS_KEY }} --body ./tableau-connector/target/neptune-jdbc-${{env.version}}.taco --acl bucket-owner-full-control | jq '.VersionId' )
version_id=$( aws s3api put-object --bucket ${{ secrets.AWS_UNSIGNED_BUCKET }} --key ${{ secrets.AWS_KEY }} --body ./tableau-connector/target/neptune-jdbc-v${{env.version}}.taco --acl bucket-owner-full-control | jq '.VersionId' )
job_id=""
# Attempt to get Job ID from bucket tagging, will retry up to 3 times before exiting with a failure code.
# Will sleep for 5 seconds between retries.
Expand Down Expand Up @@ -159,7 +159,7 @@ jobs:
done
# Downloading signed taco from S3
echo "Downloading signed .taco from S3"
aws s3api get-object --bucket ${{ secrets.AWS_SIGNED_BUCKET }} --key ${{ secrets.AWS_KEY }}-${job_id}.taco ./tableau-connector/target/neptune-jdbc-${{env.version}}-signed.taco
aws s3api get-object --bucket ${{ secrets.AWS_SIGNED_BUCKET }} --key ${{ secrets.AWS_KEY }}-${job_id}.taco ./tableau-connector/target/neptune-jdbc-v${{env.version}}-signed.taco
echo "Signing completed"
ls -l tableau-connector/target
else
Expand Down

0 comments on commit 4a7d829

Please sign in to comment.