Minor Version Upgrades & Gremlin Test Server Setup #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il with Gradle 7.5/7.6 in shadow jar building
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
========================================
Coverage 67.61% 67.61%
========================================
Files 122 122
Lines 5888 5888
Branches 585 585
========================================
Hits 3981 3981
Misses 1554 1554
Partials 353 353 ☔ View full report in Codecov by Sentry. |
kenhuuu
reviewed
Feb 29, 2024
src/test/java/software/aws/neptune/gremlin/GremlinPreparedStatementTest.java
Outdated
Show resolved
Hide resolved
kenhuuu
reviewed
Feb 29, 2024
src/test/java/software/aws/neptune/gremlin/mock/MockGremlinDatabase.java
Outdated
Show resolved
Hide resolved
kenhuuu
reviewed
Feb 29, 2024
src/test/java/software/aws/neptune/gremlin/mock/MockGremlinDatabase.java
Show resolved
Hide resolved
kenhuuu
reviewed
Feb 29, 2024
src/test/java/software/aws/neptune/gremlin/mock/MockGremlinDatabase.java
Outdated
Show resolved
Hide resolved
|
LGTM |
kenhuuu
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor Version Upgrades & Gremlin Test Server Setup
Description
Minor version upgrades for JDBC, and set up the Gremlin server dependency for testing instead of raw usage.
Related Issue
n/a
Additional Reviewers
@kenhuuu
@vkagamlyk
@alexey-temnikov
@Cole-Greer