Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eks): support for installing default networking add-ons #31822

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(eks): support for installing default networking add-ons #31822

wants to merge 5 commits into from
+7,940 −2

Conversation

badmintoncryer
Copy link
Contributor

Issue # (if applicable)

Closes #30804.

Reason for this change

Description of changes

  • Add bootstrapSelfManagedAddons prop to ClusterProps

Description of how you validated changes

Add both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 21, 2024 00:21
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Oct 21, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review October 21, 2024 13:04
sumupitchayan
sumupitchayan reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @badmintoncryer - you mention adding unit tests in the PR description but I don't see them here?

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 21, 2024
@badmintoncryer
Copy link
Contributor Author

@sumupitchayan Thanks! I've completely forgotten to add unit test. I've added it.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c289d3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumupitchayan sumupitchayan sumupitchayan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badmintoncryer @aws-cdk-automation @sumupitchayan