Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glue-alpha): add job run queuing to Glue job #31830

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jdebuseamazon
Copy link

Issue # (if applicable)

Closes #31826

Reason for this change

Job within @aws-cdk/aws-glue-alpha does not currently include the jobRunQueuingEnabled property of the CfnJob within aws-cdk-lib/aws-glue. Setting this property currently requires a raw override.

Description of changes

Added jobRunQueuingEnabled to construction properties for Job, along with validation that this is not enabled when execution class is flexible and/or maxRetries exceeds zero (see).

Description of how you validated changes

Unit tests and an integration test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 21, 2024 09:37
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Oct 21, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@jdebuseamazon jdebuseamazon changed the title feat(aws-glue-alpha): add job run queuing to Glue job feat(glue-alpha): add job run queuing to Glue job Oct 21, 2024
@jdebuseamazon
Copy link
Author

Exemption Request (for ❌ Features must contain a change to a README file): the change only introduced an optional construction property, and for consistency with existing similar construction properties such as maxCapacity and maxRetries no details were included in the README file

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 21, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 62e31a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 21, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-glue-alpha): (add jobRunQueuingEnabled to Job)
2 participants