Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda-nodejs): grammatical correction in statement reg bundleAwsSDK #31839

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

khushail
Copy link
Contributor

Issue # (if applicable)

Closes #31789

Reason for this change

Comments had grammatical mistakes.

Description of changes

Rephrased the sentence and added more clarifcation.

Description of how you validated changes

No

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 21, 2024 21:21
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Oct 21, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@khushail
Copy link
Contributor Author

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 21, 2024
@khushail khushail changed the title docs(aws-lambda-nodejs): more clarification added reg bundleawsSDK flag docs(aws-lambda-nodejs): more clarification added reg bundleawsSDK Oct 21, 2024
@khushail khushail changed the title docs(aws-lambda-nodejs): more clarification added reg bundleawsSDK docs(aws-lambda-nodejs): more clarification added reg bundleAwsSDK Oct 21, 2024
@khushail khushail changed the title docs(aws-lambda-nodejs): more clarification added reg bundleAwsSDK docs(lambda-nodejs): more clarification added reg bundleAwsSDK Oct 21, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 21, 2024 21:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@khushail khushail marked this pull request as ready for review October 21, 2024 21:41
@khushail khushail changed the title docs(lambda-nodejs): more clarification added reg bundleAwsSDK docs(lambda-nodejs): grammatical correction in statement reg bundleAwsSDK Oct 21, 2024
GavinZZ
GavinZZ previously approved these changes Oct 21, 2024
@GavinZZ GavinZZ changed the title docs(lambda-nodejs): grammatical correction in statement reg bundleAwsSDK chore(lambda-nodejs): grammatical correction in statement reg bundleAwsSDK Oct 21, 2024
@GavinZZ
Copy link
Contributor

GavinZZ commented Oct 21, 2024

@mergify update

Copy link
Contributor

mergify bot commented Oct 21, 2024

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@mergify mergify bot dismissed GavinZZ’s stale review October 22, 2024 06:03

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4c58dbe
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Oct 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f1e2f3b into main Oct 22, 2024
14 checks passed
@mergify mergify bot deleted the khushail/bundleawsSDK-readme branch October 22, 2024 06:35
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/small Small work item – less than a day of effort p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-lambda-nodejs: incomprehensible documentation for bundleAwsSDK
4 participants