fix(amplify-alpha): removing customResponseHeaders
property does not remove the headers from the app
#31844
+55
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31783.
Reason for this change
After setting the
customResponseHeaders
property to some value in the App construct, removing it again does not remove the headers in the Amplify console.Description of changes
I have set the
customHeaders
property to a default value of an empty string. This sets the relevant CloudFormation property whencustomResponseHeaders
is not provided, therefore overriding any previous values with an empty string. I took a look at a similar issue of removing basic auth from an app and saw we did something similar there - #15243.Description of how you validated changes
Updated the existing tests with the new default value.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license