Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend template-parameter definition syntax in serverless configuration #259

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jasonterando
Copy link

@jasonterando jasonterando commented Dec 18, 2022

Support object and array syntax for template-parameters configuration file setting

See description in Issue #258

Description of changes:

Update AmazonLambdaTools to check the parameter type for template-parameters.

  • [Current] If it's a string, generate a Dictionary using current syntax ("key1=value1;key2=value2;...keyN=valueN")
  • [New] If it's an object, process it using property names for keys and cast values as string
  • [New] If it's an array of strings, process it using the syntax supported by SAM, which s a list of "key=value" strings

This approach is backward compatible, it won't break usage of existing template files.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishdhingra ashishdhingra added pr/needs-review This PR needs a review from a Member. module/cli-ext queued p2 This is a standard priority issue labels Jan 27, 2023
@boblodgett boblodgett self-assigned this Jun 13, 2023
@ashishdhingra ashishdhingra requested a review from boblodgett July 17, 2023 23:36
@dscpinheiro dscpinheiro changed the base branch from master to dev September 6, 2023 15:41
@boblodgett boblodgett removed their request for review April 25, 2024 17:07
@ashishdhingra ashishdhingra requested a review from normj May 31, 2024 16:24
@normj normj changed the title Extend template-parameter definition syntax in serverless configuration [DO NOT MERGE] Extend template-parameter definition syntax in serverless configuration Nov 1, 2024
@normj normj changed the title [DO NOT MERGE] Extend template-parameter definition syntax in serverless configuration Extend template-parameter definition syntax in serverless configuration Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/cli-ext p2 This is a standard priority issue pr/needs-review This PR needs a review from a Member. queued
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants