-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new randomness generation in AWS-LC #708
Support new randomness generation in AWS-LC #708
Conversation
I'm implementation the new randomness generation and importing jitter entropy in a new way. Jitter entropy is causing issues with the aws-lc-rs build. aws/aws-lc#2220 shows the current problems. Firstly, problem with prefixing. Build errors such as
I think this can be resolved by just filtering them out during symbol analysis. The second problem is something like this:
Not sure what that is about atm. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
- Coverage 95.80% 92.89% -2.91%
==========================================
Files 61 70 +9
Lines 8143 9538 +1395
Branches 0 9538 +9538
==========================================
+ Hits 7801 8860 +1059
- Misses 342 412 +70
- Partials 0 266 +266 ☔ View full report in Codecov by Sentry. |
Description of changes:
aws/aws-lc#2220 introduces a new method to import Jitter Entropy and previous PRs added Jitter Entropy for all build types.
This didn't quite work with aws-lc-rs build that only expected Jitter Entropy for some select FIPS builds.
Testing:
Following succeded"
It simulates https://github.com/aws/aws-lc/blob/main/.github/workflows/aws-lc-rs.yml#L16 with aws/aws-lc#2220.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.