-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing algorithms to benchmark #2056
Open
nhatnghiho
wants to merge
7
commits into
aws:main
Choose a base branch
from
nhatnghiho:benchmark-algo-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
+ Coverage 79.05% 79.06% +0.01%
==========================================
Files 612 612
Lines 106218 106218
Branches 15006 15007 +1
==========================================
+ Hits 83970 83985 +15
+ Misses 21595 21582 -13
+ Partials 653 651 -2 ☔ View full report in Codecov by Sentry. |
andrewhop
previously approved these changes
Dec 12, 2024
deb86da
to
9fb0005
Compare
justsmth
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves i/CryptoAlg-2808
Description of changes:
Add the following missing algorithms to
speed.cc
so we can view the benchmark on our dashboards:rc4
md5-sha1
,ripemd-160
,shake128
,shake256
Call-outs:
N/A
Testing:
CI. Verified that
bssl
runs successfully locally.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.