Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal IANA values of PQ SupportedGroups #2235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexw91
Copy link
Contributor

@alexw91 alexw91 commented Mar 3, 2025

Issues:

N/A

Description of changes:

Pulls in the latest IANA SupportedGroup identifiers from draft RFC's/IANA.
See: https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8

Call-outs:

The IANA values of SSL_GROUP_MLKEM768 and SSL_GROUP_MLKEM1024 changed. This PR to change their values is safe because AWS-LC does not support negotiating ML-KEM groups as standalone, only as hybrid when combined with ECDH. These standalone ML-KEM IANA values were never sent/received over the wire during any TLS handshakes by AWS-LC.

Testing:

Unit Tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@alexw91 alexw91 requested a review from a team as a code owner March 3, 2025 21:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (1d8b807) to head (99e7b82).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2235      +/-   ##
==========================================
- Coverage   79.06%   79.05%   -0.01%     
==========================================
  Files         612      612              
  Lines      106513   106513              
  Branches    15052    15053       +1     
==========================================
- Hits        84216    84208       -8     
- Misses      21645    21653       +8     
  Partials      652      652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants