Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ML-DSA to break-kat framework #2253

Merged
merged 5 commits into from
Mar 7, 2025
Merged

Added ML-DSA to break-kat framework #2253

merged 5 commits into from
Mar 7, 2025

Conversation

jakemas
Copy link
Contributor

@jakemas jakemas commented Mar 6, 2025

Issues:

Resolves #PQCrypto-130

Description of changes:

  • Added ML-DSA to the break-kat tool.

Call-outs:

As the break kat test modifies input to switch it all out for zeros, I had to change the kMLDSASignPlaintext in self_check.c to no longer be all zeros. As such the expected signature also has changed.

We also are no longer able to re-use the signature from ML-DSA-sign in ML-DSA-verify as we want to break the verify KAT independently of the sign KAT. As such, kMLDSAVerifySignature and kMLDSAVerifyPlaintext have been added.

Testing:

Running break-kat and callback tests both pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.06%. Comparing base (4fb8ec3) to head (1ba9f3d).

Files with missing lines Patch % Lines
crypto/fipsmodule/self_check/self_check.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2253   +/-   ##
=======================================
  Coverage   79.05%   79.06%           
=======================================
  Files         612      612           
  Lines      106517   106521    +4     
  Branches    15053    15053           
=======================================
+ Hits        84204    84217   +13     
+ Misses      21661    21650   -11     
- Partials      652      654    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakemas jakemas mentioned this pull request Mar 7, 2025
@jakemas jakemas marked this pull request as ready for review March 7, 2025 00:20
@jakemas jakemas requested a review from a team as a code owner March 7, 2025 00:20
@jakemas jakemas changed the title break-kat for ML-DSA Added ML-DSA to break-kat framework Mar 7, 2025
@andrewhop andrewhop merged commit 9b814f0 into aws:main Mar 7, 2025
104 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants