Avoid double seed for non-UBE support runtimes #2259
+57
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In the non-UBE support runtime, a fresh lazy init will spawn a seed of the CTR-DRBG state. But then in
rand_bytes_core()
, there will be an immediate spawn of a reseed of the CTR-DRBG state to ensure uniqueness for non-UBE support.Fix this by telling
rand_bytes_core
whether the CTR-DRBG state is fresh or not.This requires a few changes in the tests to account for a reseed that might not happen. Now I'm there, refactor a bit.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.