driver: wrap fd returned from nsm_init in Option #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning an Option instead of the raw file descriptor makes it easier for the caller to ensure that the file was opened successfully. It also forces them to handle any errors instead of allowing them to assume that it was successful, only to be met with "InternalError" when nsm_process_request is later used.
tannaurus
reviewed
Oct 13, 2024
| let mut open_options = OpenOptions::new(); | ||
| let open_dev = open_options.read(true).write(true).open(DEV_FILE); | ||
|
|
||
| match open_dev { | ||
| Ok(open_dev) => { | ||
| debug!("Device file '{}' opened successfully.", DEV_FILE); | ||
| open_dev.into_raw_fd() | ||
| Some(open_dev.into_raw_fd()) |
There was a problem hiding this comment.
Semantically, this should be a Result.
There was a problem hiding this comment.
Generally agreed, but this is the pattern used in this repo. I was trying to make it as appetizing as possible for the maintainers. I'm happy to change it though. (Are you in a position to merge this PR?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning an Option instead of the raw file descriptor makes it easier for the caller to ensure that the file was opened successfully. It also forces them to handle any errors instead of allowing them to assume that it was successful, only to be met with "InternalError" when nsm_process_request is later used.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.