fix s3 move and copy, assignment operator with custom credentials #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
approved these changes
Dec 26, 2023
DmitriyMusatkin
approved these changes
Dec 26, 2023
sbiscigl
force-pushed
the
fix-s3-copy-assignemnt
branch
2 times, most recently
from
e4e4151 to
021da46
Compare
sbiscigl
changed the title
DmitriyMusatkin
approved these changes
Dec 27, 2023
sbiscigl
changed the title
sbiscigl
force-pushed
the
fix-s3-copy-assignemnt
branch
from
021da46 to
8f5b93a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There was a previous change to fix the copy constructor for s3, which fixed copy constructors, but missed copy assignment. This changes the copy assignment to operator to create a client with the existing credentials.
This also update to add move constructors to client.
To be clear, we advise not using copy ctors or assignment and are debating removing them in future releases to prevent inefficent workflows.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.