Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-sdk-s3): safely access nested properties for error #5580

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

siddsriv
Copy link
Contributor

@siddsriv siddsriv commented Dec 13, 2023

Issue

#5554

Description

for region redirect middleware -- safely access nested properties for error, namely $metadata and httpStatusCode

Testing

.
.
PASS  src/region-redirect-middleware.spec.ts (6.543 s)
.
.
Test Suites: 9 passed, 9 total
Tests:       20 passed, 20 total
Snapshots:   0 total
Time:        6.868 s
Ran all test suites.
Done in 7.36s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested a review from a team as a code owner December 13, 2023 18:57
@siddsriv siddsriv merged commit 013665e into aws:main Dec 13, 2023
2 checks passed
@siddsriv siddsriv deleted the fix/5554 branch December 13, 2023 23:59
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants