fix(core): wrap credentialDefaultProvider with normalizeProvider

[syall]

Issue

Issue number, if available, prefixed with "#"

#5591

Description

What does this implement/fix? Explain your changes.

Wrap credentialDefaultProvider with normalizeProvider.

Testing

How was this change tested?

Using the repro from: #5591, and also testing it without a configured credentialDefaultProvider:

const { STSClient, GetCallerIdentityCommand } = require("@aws-sdk/client-sts")

const client = new STSClient({
    "region": "us-west-2"
})
const command = new GetCallerIdentityCommand({})

client.send(command).then((res) => { console.log(res) }).catch((err) => { console.log("ERR:", err) })

Additional context

Add any other context about the PR here.

When passing in defaultProvider like done in the repro, the types are actually NOT compatible.

// defaultProvider matches
defaultProvider: (init?: DefaultProviderInit) => MemoizedProvider<AwsCredentialIdentity>;

// credentialDefaultProvider type on clients
credentialDefaultProvider?: (input: any) => AwsCredentialIdentityProvider;

If you pass in like in the repro:

let { getDefaultRoleAssumerWithWebIdentity, STSClient, GetCallerIdentityCommand } = require("@aws-sdk/client-sts")
let { defaultProvider } = require("@aws-sdk/credential-provider-node")

// This is actually type `MemoizedProvider<AwsCredentialIdentity>`, not `(input: any) => AwsCredentialIdentityProvider`
const provider = defaultProvider({"roleAssumerWithWebIdentity": getDefaultRoleAssumerWithWebIdentity})
const client = new STSClient({
    "credentialDefaultProvider": provider,
    "region": "us-west-2"
})
const command = new GetCallerIdentityCommand({})

client.send(command).then((res) => { console.log(res) }).catch((err) => { console.log("ERR:", err) })

To make the types work, the code should be like this

let { getDefaultRoleAssumerWithWebIdentity, STSClient, GetCallerIdentityCommand } = require("@aws-sdk/client-sts")
let { defaultProvider } = require("@aws-sdk/credential-provider-node")

// Make it match `(input: any) => AwsCredentialIdentityProvider` by wrapping it in a function
const provider = () =>  defaultProvider({"roleAssumerWithWebIdentity": getDefaultRoleAssumerWithWebIdentity})
const client = new STSClient({
    "credentialDefaultProvider": provider,
    "region": "us-west-2"
})
const command = new GetCallerIdentityCommand({})

client.send(command).then((res) => { console.log(res) }).catch((err) => { console.log("ERR:", err) })

This PR is to ensure existing code still works, but should not be encouraged.

Checklist

• If you wrote E2E tests, are they resilient to concurrent I/O?
• If adding new public functions, did you add the @public tag and enable doc generation on the package?

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.