fix(crc64-nvme-crt): return checksum for empty string if called without data #6798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddsriv
approved these changes
Jan 14, 2025
kuhe
reviewed
Jan 14, 2025
| @@ -3,20 +3,17 @@ import { Checksum } from "@smithy/types"; | |||
| import { toUint8Array } from "@smithy/util-utf8"; | |||
|
|
|||
| export class CrtCrc64Nvme implements Checksum { | |||
| private previous: DataView | undefined; | |||
| private checksum: DataView = new DataView(new ArrayBuffer(8)); | |||
There was a problem hiding this comment.
very minor issue:
given that CrtCrc64Nvme implements Checksum, an instance of this may be called "checksum", so this private property would be checksum.checksum.
perhaps it would more correctly be called "hash"?
There was a problem hiding this comment.
I'll update this in a separate PR, since we use checksum for the private member in NodeCrc32 too.
kuhe
approved these changes
Jan 14, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-5674
Description
Returns checksum for empty string if called without data
Testing
Verified using internal test code that CRC64VME checksum if
"AAAAAAAAAAA="when called for empty string.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.