Update isNoWorkToDoValidationError to widen scope of error messages included #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a function that determines if an error occurred when processing a Cloudformation stack Create Or Update, it appears the at least one of the error messages returned by the AWS API have changed slightly and this update is to make a slight change to the known error messages validation to ensure that the updated error from AWS can be handled by this function.
The error message causing the issue is "CloudFormation failed to preprocess the stack: No updates are to be performed." the current code looks for errors starting with "No updates are to be performed." but it appears AWS has modified the error message to include the additional wording "CloudFormation failed to preprocess the stack: ".
Motivation
This issue currently breaks Azure DevOps pipelines that use the aws-toolkit to perform Cloudformation stack updates where no changes are to be applied, this sometimes happens when a pipeline is re-run using the same Cloudformation template. It has been fixed a couple of times in the past and this is a new iteration on that.
Related Issue(s), If Filed
No related issues.
Testing
Changes tested locally to verify the update works as expected.
Checklist
npm run newChange
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.