Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hook ISO image to eksa bundles #9205

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

rahulbabu95
Copy link
Member

@rahulbabu95 rahulbabu95 commented Jan 25, 2025

Issue #, if available:

Description of changes:
#4256 adds Hook OS as an ISO image in our build tooling. Update our bundle to start shipping Hook as ISO which will be consumed when user wants to boot the machine using an ISO for L3 provisioning.

Testing (if applicable):

  • make release
  • make manifest
  • make release-manifest
  • make update-bundle-golden-files
  • make generate-manifests

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rahulbabu95 rahulbabu95 force-pushed the l3/add-iso-to-bundles branch from 94a5af8 to a72c157 Compare January 25, 2025 02:40
@rahulbabu95
Copy link
Member Author

/hold

@eks-distro-bot eks-distro-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/hold labels Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.37%. Comparing base (0ac372d) to head (5c3631c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9205   +/-   ##
=======================================
  Coverage   72.37%   72.37%           
=======================================
  Files         585      585           
  Lines       45708    45708           
=======================================
+ Hits        33079    33082    +3     
+ Misses      10890    10888    -2     
+ Partials     1739     1738    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulbabu95 rahulbabu95 force-pushed the l3/add-iso-to-bundles branch from a72c157 to d3dc447 Compare January 28, 2025 01:18
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2025
@rahulbabu95 rahulbabu95 force-pushed the l3/add-iso-to-bundles branch 3 times, most recently from 37b0749 to 9739a0c Compare January 28, 2025 01:40
@rahulbabu95 rahulbabu95 force-pushed the l3/add-iso-to-bundles branch from 9739a0c to 5c3631c Compare January 28, 2025 01:55
@rahulbabu95
Copy link
Member Author

/approve

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,rahulbabu95]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rahulbabu95
Copy link
Member Author

/unhold

@eks-distro-bot eks-distro-bot merged commit 58bb49c into aws:main Jan 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants