Remove edge counts (#733)

* Remove unused __fetchedOutEdgeCount * Remove unused __fetchedInEdgeCount
aws · Jan 7, 2025 · e03a5dd · e03a5dd
1 parent ea271ad
commit e03a5dd
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 30 deletions.
diff --git a/packages/graph-explorer/src/@types/entities.ts b/packages/graph-explorer/src/@types/entities.ts
@@ -72,14 +72,6 @@ export type Vertex = {
    * Non-fetched neighbors by type
    */
   __unfetchedNeighborCounts?: Record<string, number>;
-  /**
-   * Fetched incoming edges connected with the vertex
-   */
-  __fetchedInEdgeCount?: number;
-  /**
-   * Fetched outgoing edges connected with the vertex
-   */
-  __fetchedOutEdgeCount?: number;
 };
 
 export type Edge = {

diff --git a/packages/graph-explorer/src/core/StateProvider/entitiesSelector.ts b/packages/graph-explorer/src/core/StateProvider/entitiesSelector.ts
@@ -126,8 +126,6 @@ const entitiesSelector = selector<Entities>({
           <Vertex>{
             ...node,
             __unfetchedNeighborCounts,
-            __fetchedOutEdgeCount: outConnections.length,
-            __fetchedInEdgeCount: inConnections.length,
             __unfetchedNeighborCount: Math.max(
               0,
               Object.values(__unfetchedNeighborCounts).reduce(

diff --git a/packages/graph-explorer/src/hooks/useAddToGraph.test.ts b/packages/graph-explorer/src/hooks/useAddToGraph.test.ts
@@ -26,8 +26,6 @@ test("should add one node", async () => {
   const actual = result.current.entities.nodes.get(vertex.id);
   expect(actual).toEqual({
     ...vertex,
-    __fetchedInEdgeCount: 0,
-    __fetchedOutEdgeCount: 0,
     __unfetchedNeighborCount: 0,
     __unfetchedNeighborCounts: {},
   });
@@ -79,8 +77,6 @@ test("should add multiple nodes and edges", async () => {
     .values()
     .map(n => ({
       ...n,
-      __fetchedInEdgeCount: 2,
-      __fetchedOutEdgeCount: 2,
       __unfetchedNeighborCount: 0,
       __unfetchedNeighborCounts: {},
     }))

diff --git a/packages/graph-explorer/src/hooks/useEntities.test.tsx b/packages/graph-explorer/src/hooks/useEntities.test.tsx
@@ -34,8 +34,6 @@ describe("useEntities", () => {
       ...randomNode,
       neighborsCountByType: {},
       __unfetchedNeighborCounts: {},
-      __fetchedOutEdgeCount: 0,
-      __fetchedInEdgeCount: 0,
       __unfetchedNeighborCount: 0,
     };
 
@@ -61,8 +59,6 @@ describe("useEntities", () => {
     expect(actualNode?.neighborsCount).toEqual(randomNode.neighborsCount);
     expect(actualNode?.neighborsCountByType).toEqual({});
     expect(actualNode?.__unfetchedNeighborCounts).toEqual({});
-    expect(actualNode?.__fetchedOutEdgeCount).toEqual(0);
-    expect(actualNode?.__fetchedInEdgeCount).toEqual(0);
     expect(actualNode?.__unfetchedNeighborCount).toEqual(0);
   });
 
@@ -104,8 +100,6 @@ describe("useEntities", () => {
         neighborsCount: node1.neighborsCount,
         neighborsCountByType: {},
         __unfetchedNeighborCounts: {},
-        __fetchedOutEdgeCount: 0,
-        __fetchedInEdgeCount: 0,
         __unfetchedNeighborCount: 0,
       },
       {
@@ -117,8 +111,6 @@ describe("useEntities", () => {
         neighborsCount: node2.neighborsCount,
         neighborsCountByType: {},
         __unfetchedNeighborCounts: {},
-        __fetchedOutEdgeCount: 0,
-        __fetchedInEdgeCount: 0,
         __unfetchedNeighborCount: 0,
       },
       {
@@ -130,8 +122,6 @@ describe("useEntities", () => {
         neighborsCount: node3.neighborsCount,
         neighborsCountByType: {},
         __unfetchedNeighborCounts: {},
-        __fetchedOutEdgeCount: 0,
-        __fetchedInEdgeCount: 0,
         __unfetchedNeighborCount: 0,
       },
     ]);
@@ -159,8 +149,6 @@ describe("useEntities", () => {
     expect(actualNode1?.neighborsCount).toEqual(node1.neighborsCount);
     expect(actualNode1?.neighborsCountByType).toEqual({});
     expect(actualNode1?.__unfetchedNeighborCounts).toEqual({});
-    expect(actualNode1?.__fetchedOutEdgeCount).toEqual(0);
-    expect(actualNode1?.__fetchedInEdgeCount).toEqual(0);
     expect(actualNode1?.__unfetchedNeighborCount).toEqual(0);
 
     const actualNode2 = result.current.entities.nodes.get(node2.id);
@@ -170,8 +158,6 @@ describe("useEntities", () => {
     expect(actualNode2?.neighborsCount).toEqual(node2.neighborsCount);
     expect(actualNode2?.neighborsCountByType).toEqual({});
     expect(actualNode2?.__unfetchedNeighborCounts).toEqual({});
-    expect(actualNode2?.__fetchedOutEdgeCount).toEqual(0);
-    expect(actualNode2?.__fetchedInEdgeCount).toEqual(0);
     expect(actualNode2?.__unfetchedNeighborCount).toEqual(0);
 
     const actualNode3 = result.current.entities.nodes.get(node3.id);
@@ -181,8 +167,6 @@ describe("useEntities", () => {
     expect(actualNode3?.neighborsCount).toEqual(node3.neighborsCount);
     expect(actualNode3?.neighborsCountByType).toEqual({});
     expect(actualNode3?.__unfetchedNeighborCounts).toEqual({});
-    expect(actualNode3?.__fetchedOutEdgeCount).toEqual(0);
-    expect(actualNode3?.__fetchedInEdgeCount).toEqual(0);
     expect(actualNode3?.__unfetchedNeighborCount).toEqual(0);
   });