Skip to content

Commit

Permalink
Modify parameter name
Browse files Browse the repository at this point in the history
  • Loading branch information
timjell committed Dec 15, 2022
1 parent 9478824 commit 7babfd0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/QMRNotificationUtility/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Version 2.0 has had significant changes to the code.
* Redshift queries submitted via Data API, not via ODBC connection
* No password details required. Data API calls obtain temporary database credentials. Permission to call the `redshift:GetClusterCredentials` operation is required. See the [Data API Documentation](https://docs.aws.amazon.com/redshift/latest/mgmt/data-api.html)
* The cluster identifier used is NOT the same as the cluster endpoint. Instead of creating the stack with the `RedshiftClusterEndpoint` havivng the value of `cluster-name.random-letters.region.redshift.amazonaws.com` only the cluster identifier such as `cluster-name` is required.
* The cluster identifier used is NOT the same as the cluster endpoint. Instead of creating the stack with the `RedshiftClusterIdentifier` having the value of `cluster-name.random-letters.region.redshift.amazonaws.com` only the cluster identifier such as `cluster-name` is required.
* Future updates will allow the utility to be utilised with serverless clusters. This release is limited to provisioned clusters only.

## Goals
Expand Down Expand Up @@ -81,7 +81,7 @@ aws cloudformation create-stack \
ParameterKey=SecurityGroupIds,ParameterValue=sg-abcd1234 \
ParameterKey=RedshiftMonitoringUser,ParameterValue=monitoring_user \
ParameterKey=RedshiftClusterPort,ParameterValue=cluster_port \
ParameterKey=RedshiftClusterEndpoint,ParameterValue=examplecluster \
ParameterKey=RedshiftClusterIdentifier,ParameterValue=examplecluster \
ParameterKey=RedshiftClusterDatabase,ParameterValue=db_name \
--capabilities CAPABILITY_IAM
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Metadata:
Parameters:
- RedshiftMonitoringUser
- RedshiftClusterPort
- RedshiftClusterEndpoint
- RedshiftClusterIdentifier
- RedshiftClusterDatabase
- RedshiftClusterRegion
Parameters:
Expand All @@ -50,7 +50,7 @@ Parameters:
RedshiftClusterPort:
Description: Port of Amazon Redshift cluster to attempt connection from Lambda on.
Type: Number
RedshiftClusterEndpoint:
RedshiftClusterIdentifier:
Description: Amazon Redshift cluster endpoint to attempt connection from Lambda on.
Type: String
RedshiftClusterDatabase:
Expand Down Expand Up @@ -133,7 +133,7 @@ Resources:
Environment:
Variables:
sns_arn: !Ref 'LambdaSNSTopic'
host: !Ref 'RedshiftClusterEndpoint'
host: !Ref 'RedshiftClusterIdentifier'
port: !Ref 'RedshiftClusterPort'
database: !Ref 'RedshiftClusterDatabase'
user: !Ref 'RedshiftMonitoringUser'
Expand Down

0 comments on commit 7babfd0

Please sign in to comment.