Rename OpenFileInformation to OpenStreamInformation #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stubz151
reviewed
Feb 21, 2025
| @@ -185,8 +185,6 @@ public CompletableFuture<ObjectContent> getObject( | |||
| referrerHeader = getRequest.getReferrer().toString(); | |||
| } | |||
|
|
|||
| LOG.info("auditHeaders {}", referrerHeader); | |||
There was a problem hiding this comment.
Is this logger still needed?
| @@ -26,11 +26,11 @@ | |||
| */ | |||
There was a problem hiding this comment.
nit: These doc should be updated. It still says Open file information.
stubz151
reviewed
Feb 21, 2025
| * @return the file format of the object | ||
| */ | ||
| public ObjectFormat getObjectFormat(S3URI s3URI, OpenFileInformation openFileInformation) { | ||
| public ObjectFormat getObjectFormat(S3URI s3URI, OpenStreamInformation openStreamInformation) { | ||
|
|
||
| // If the supplied policy in open file information is Sequential, then use the default input |
There was a problem hiding this comment.
still says Open file information
stubz151
reviewed
Feb 21, 2025
| @@ -38,19 +38,19 @@ public ObjectFormatSelector(LogicalIOConfiguration configuration) { | |||
| * Uses a regex matcher to select the file format based on the file extension of the key. | |||
| * | |||
| * @param s3URI the object's S3 URI | |||
| * @param openFileInformation known file information for the file | |||
| * @param openStreamInformation known file information for the file | |||
There was a problem hiding this comment.
- @param openStreamInformation known file information for the file
should be known stream info?
| @@ -103,23 +103,25 @@ public S3SeekableInputStream createStream(@NonNull S3URI s3URI, ObjectMetadata m | |||
| * Creates an instance of SeekableStream with file information | |||
| * | |||
| * @param s3URI the object's S3 URI | |||
| * @param openFileInformation known file information this key | |||
| * @param openStreamInformation known file information this key | |||
There was a problem hiding this comment.
- @param openStreamInformation known file information for the file
should be stream right?
stubz151
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Just a rename!
Relevant issues
Does this contribution introduce any breaking changes to the existing APIs or behaviors?
Does this contribution introduce any new public APIs or behaviors?
How was the contribution tested?
Does this contribution need a changelog entry?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).