Simple logging API; defaults to console #560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
reviewed
Jul 29, 2024
| FATAL = 1, | ||
| /** Only errors */ | ||
| ERROR = 2, | ||
| /** Only warnings and errors */ |
There was a problem hiding this comment.
Extremely Trivial: This is the only comment that explicitly calls out itself along with another log category. It's unlikely but this may cause someone to assume that later levels are not inclusive of previous log levels.
sbSteveK
reviewed
Jul 29, 2024
|
|
||
| /** | ||
| * Sets the amount of detail that will be logged | ||
| * @param level - maximum level of logging detail. Log invocations at a higher level of detail will be ignored. |
There was a problem hiding this comment.
Related: This deffo clears up the issue above for the most part.
sbSteveK
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for MQTT request-response browser implementation. If reasonable, we should add lightweight logging to MQTT wrappers as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.