Continuous Delivery nodejs version bump #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why? Please, in all pull requests explain WHY you're doing things. Explain the problem you encountered, and why this will fix it. |
graebm
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the install phase nodejs version from 10 to 14 in continuous-delivery related yml files.
CD is currently failing at the POST_BUILD phase of the aws-crt-nodejs-cd-combine-binaries CodeBuild Build Project with the context "COMMAND_EXECUTION_ERROR: Error while executing command: bash ./continuous-delivery/pack.sh. Reason: exit status 1"
logs indicate:
npx tsc -p tsconfig.json
Unexpected token ?
run(
npx tsc -p tsconfig.json) is in thescripts/tsc.jsWhich is listed in the "prepare": "node ./scripts/tsc.js && node ./scripts/install.js" of the package.json.
The related yml file for pack sets the runtime-version of nodejs to 10. Changing this to our minimum supported version of 14 should resolve the issue. We may as well also bump the version from 10 -> 14 in the publish and test-version-exists files as well since I'm expecting the same issue in those locations.
This solution was tested locally where running
npx tsc -p tsconfig.jsonresulted in no error when using node 14 but generated an identical "Unexpected token ?" error when using Node 10.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.