Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added run uuid in CSV output #92

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Added run uuid in CSV output #92

merged 5 commits into from
Jan 24, 2025

Conversation

goginea
Copy link
Contributor

@goginea goginea commented Jan 24, 2025

This PR adds run uuid to be included in the CSV output when omics run analyzer is run

@markjschreiber
Copy link
Contributor

This will add the uuid header to the output CSV, but does it actually add UUID values to the rows below the header? You may have to extract and add the uuid in the add_metrics function on line 333.

@markjschreiber
Copy link
Contributor

Also, add the UUID description to this section

@goginea
Copy link
Contributor Author

goginea commented Jan 24, 2025

This will add the uuid header to the output CSV, but does it actually add UUID values to the rows below the header? You may have to extract and add the uuid in the add_metrics function on line 333.

Yes, locally tested that the uuid is correctly added to the headers, and the correct uuid value is displayed in the CSV file.

@goginea
Copy link
Contributor Author

goginea commented Jan 24, 2025

Also, add the UUID description to this section

Added to README.

@markjschreiber
Copy link
Contributor

closes #88

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for adding this.

@markjschreiber markjschreiber merged commit 84c420d into awslabs:main Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants