Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdlf-dataset][cdk] remove pPipelineDetails parameter #429

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[sdlf-dataset][cdk] remove pPipelineDetails parameter #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions sdlf-dataset/src/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,27 +117,6 @@ def __init__(self, scope: Construct, id: str, **kwargs) -> None:
default="",
)
p_cicdrole.override_logical_id("pCicdRole")
p_pipelinedetails = CfnParameter(
self,
"pPipelineDetails",
type="String",
default="""
{
"main": {
"B": {
"glue_capacity": {
"NumberOfWorkers": 10,
"WorkerType": "G.1X"
},
"glue_extra_arguments": {
"--enable-auto-scaling": "true"
}
}
}
}
""",
)
p_pipelinedetails.override_logical_id("pPipelineDetails")

######## KMS #########
infra_kms_key_policy = iam.PolicyDocument(
Expand Down Expand Up @@ -1104,28 +1083,13 @@ def __init__(self, scope: Construct, id: str, **kwargs) -> None:
string_value=manifests_table.table_name,
)

ssm.StringParameter(
self,
"rDatasetSsm",
description=f"Placeholder {p_datasetname.value_as_string}",
parameter_name=f"/SDLF/Datasets/{p_datasetname.value_as_string}",
simple_name=False, # parameter name is a token
string_value=p_pipelinedetails.value_as_string, # bit of a hack for datasets lambda
)

# CloudFormation Outputs TODO
CfnOutput(
self,
"oPipelineReference",
description="CodePipeline reference this stack has been deployed with",
value=p_pipelinereference.value_as_string,
)
CfnOutput(
self,
"oPipelineTransforms",
description="Transforms to put in DynamoDB",
value=p_pipelinedetails.value_as_string,
)

def data_catalog(self, scope, org, domain, dataset, bucket_layer, bucket, s3_prefix):
glue_catalog = glue_a.Database(
Expand Down
Loading