-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new MetricRepository to read and write data via REST #445
base: master
Are you sure you want to change the base?
Conversation
Adding new MetricRepository for reading and writing data through REST
@shehzad-qureshi @eycho-am @sseb @sseb Can you review this PR? |
Thank you for the pull request. Can you please share more details about your use case? Can you also attach any testing evidence that showcases how the changes work? |
@cmachgodaddy Can you provide an update on my comment above? |
Hi @rdsharma26 , sorry for the late response. My use case was as bellow: Another reason it has to be API is our existing metric has its own schema which is not compatible with the schema that Deequ's Anomaly Detection expected. So providing this API as a abstraction layer has the flexibility to convert the schema from one format to another. I have used this REST repo for a while now, and in production, and it works quite well. Here is how I used it
And, here is how I run the Anomaly Detection job, and send data to Dynamo
These should be in the PR, btw. I can't snapshot the results in my Dynamo, since it contains some sensitive data. But, the changes in this PR should be very straightforward? it based off the existing patterns of the FileSystem and the InMemory repos. Let me know if you need anything else to get this PR in? |
Issue #, if available:
Description of changes:
Adding new MetricRepository to read and write data via REST
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.