Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Features Per Issue 579 #580

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jasonhorner
Copy link

Issue #, if available:
#579

Description of changes:

  • Added support for validating US phone numbers and US postal codes in the PatternMatch analyzer by incorporating the following regex patterns:
    1. US Phone Number Regex:
      val PHONE_NUMBER_US: Regex = """^(?:\+1\s?)?(?:\(?[2-9][0-9]{2}\)?[\s-]?)?[2-9][0-9]{2}[\s-]?[0-9]{4}(?:\s?(?:ext|x|extension)\s?[0-9]{4})?$""".r
    2. US Postal Code Regex:
      val POSTAL_CODE_US: Regex = """\b\d{5}(?:-\d{4})?\b""".r
  • Updated the PatternMatch examples and unit tests to include these new patterns for validation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jasonhorner
Copy link
Author

I'm looking for feedback on this PR. I think it is ready to go. I can promote it to a full PR once I get some indication that I'm headed in the right direction. I'd like to also fix #533 but can do that as a separate PR if that is desirable.

Adding Link to synapse install instructions.
adding instructions
@jasonhorner jasonhorner marked this pull request as ready for review September 14, 2024 19:28
@jasonhorner
Copy link
Author

is anyone available to review this and help me get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant