Add optional bandwidth monitoring to benchmark.py #1289
+82
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses bwm-ng, which probably needs to be installed, therefore this is behind a default-false configuration flag `with_bwm`. Outputs a csv file under the experiment output with the bandwidth on each NIC every 0.5s. (cherry picked from commit bff5072) Signed-off-by: Sahitya Damera <[email protected]>
sahityadg
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
sahityadg
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
sahityadg
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
sahityadg
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
sahityadg
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
sahityadg
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
sahityadg
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
muddyfish
reviewed
Feb 26, 2025
Signed-off-by: Sahitya Damera <[email protected]>
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
previously approved these changes
Feb 27, 2025
Signed-off-by: Sahitya Damera <[email protected]>
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
approved these changes
Feb 27, 2025
dannycjones
reviewed
Feb 27, 2025
| """ | ||
| f = open(output_file, 'w') | ||
| self.output_files.append(f) | ||
| log.debug(f"Starting monitoring tool {''.join(process_args)}") |
There was a problem hiding this comment.
I think this will output the args but with no spaces :(
Suggested change
| log.debug(f"Starting monitoring tool {''.join(process_args)}") | |
| log.debug(f"Starting monitoring tool {' '.join(process_args)}") |
adpeace
reviewed
Mar 3, 2025
| for output_file in self.output_files: | ||
| self._close_output_file(output_file) | ||
|
|
||
| def _close_output_file(self, output_file): |
There was a problem hiding this comment.
nit: does this really need to be its own method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses bwm-ng, which probably needs to be installed, therefore this is behind a default-false configuration flag
with_bwm. Outputs a csv file under the experiment output with the bandwidth on each NIC every 0.5s.(cherry picked from commit bff5072)
Does this change impact existing behavior?
No change to Mountpoint, an update to benchmark script only.
Does this change need a changelog entry? Does it require a version change?
No Mountpoint change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).