Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update eslint rule #121

Merged
merged 2 commits into from
Oct 31, 2023
Merged

chore: update eslint rule #121

merged 2 commits into from
Oct 31, 2023

Conversation

Keith-Web3
Copy link
Contributor

@Keith-Web3 Keith-Web3 commented Oct 29, 2023 •
edited by franher
Loading

Pull Request Template

Fixes #46

PR Checklist

  • I have run npm test locally and all tests are passing.
  • [] I have added/updated tests for any new behavior.
  • [] I have added/updated documentation for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: update eslint rule to avoid unnecessary warning #46

PR Description

Changed the "class-methods-use-this" field in eslintrc from "warn" to ["error", { "enforceForClassFields": false }] so classes don't just get a warning when they use the "this" keyword incorrectly but they error.

@Keith-Web3 Keith-Web3 requested a review from a team as a code owner October 29, 2023 12:04
@franher franher changed the title Updated eslint "class-methods-use-this" warning. chore: update eslint rule Oct 31, 2023
franher
franher approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@franher franher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franher franher merged commit 8f12e89 into axa-group:main Oct 31, 2023
12 of 13 checks passed
@Keith-Web3 Keith-Web3 deleted the update-eslint branch October 31, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franher franher franher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update eslint rule to avoid unnecessary warning
2 participants
@Keith-Web3 @franher