Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tools dir to ampd Dockerfile #758

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

eguajardo
Copy link
Contributor

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Convention Checklist

  • Each contract should have a client mod for others to interact with it.
  • Derive macros
  • The state mod and msg mod should use separate data structures so that internal state changes do not break the contract interface. Check out the interchain-token-service for reference.
    • msg.rs should never use any type from the state.rs
    • Shared types must be defined in a separate exported mod. If those types have already been defined somewhere else, then they should get re-exported in the exported mod

Steps to Test

Expected Behaviour

Notes

@eguajardo eguajardo requested review from a team as code owners February 7, 2025 21:08
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (e1cf35f) to head (27702d8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files         225      225           
  Lines       36516    36516           
=======================================
  Hits        34165    34165           
  Misses       2351     2351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eguajardo eguajardo merged commit 870d1df into main Feb 7, 2025
9 checks passed
@eguajardo eguajardo deleted the fix/tools-breaking-docker branch February 7, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants