feat: audit address comments #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milapsheth
approved these changes
May 18, 2024
milapsheth
added a commit
that referenced
this pull request
May 26, 2024
* Made the squid changes * some cleanup * Making sure all txns are executed as part of await * Trying to finalize Txns before the next one happens * add coverage * try moving different things into bin * testing stuff * more tests * fixed tests * Update .github/workflows/codecov.yaml Co-authored-by: Milap Sheth <[email protected]> * Update move/squid/sources/squid/swap_info.move Co-authored-by: Milap Sheth <[email protected]> * fix a small bug * remove code coverage * added squid deployment * feat: audit address comments (#28) * Addressed all relevant audit comments * added some comments * fixed tests * Update move/axelar/sources/gateway.move * Update move/axelar/sources/gateway.move * rename --------- Co-authored-by: Milap Sheth <[email protected]> --------- Co-authored-by: Milap Sheth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://axelarnetwork.atlassian.net/browse/AXE-4001