Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist MVX #19

Closed
wants to merge 1 commit into from
Closed

Conversation

0xrmvdao
Copy link
Contributor

@0xrmvdao 0xrmvdao commented Feb 9, 2024

No description provided.

"axelarChainId": "linea",
"tokenAddress": "0x0018D96C579121a94307249d47F053E2D687b5e7",
"tokenManager": "0x7569B178CcF8709E6850b3b0873Be5380e04668b",
"tokenManagerType": "unknown"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tokenManagerType": "unknown"
"tokenManagerType": "mintBurn"

@canhtrinh @alanrsoares looks like token manager wasn't retrieved here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this was recorded as unknown. @alanrsoares can you investigate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was fixed in the persistance layer

"axelarChainId": "scroll",
"tokenAddress": "0x0018D96C579121a94307249d47F053E2D687b5e7",
"tokenManager": "0x7569B178CcF8709E6850b3b0873Be5380e04668b",
"tokenManagerType": "lockUnlock"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tokenManagerType": "lockUnlock"
"tokenManagerType": "mintBurn"

remote token for a canonical interchain token has mint burn token manager type. @canhtrinh @alanrsoares can you fix the wizard here? It would also be good to more checks such as only allowing one manager to be lockUnlock type

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milapsheth yeah we fixed the scripts

@@ -9,8 +9,7 @@
"codegen:schemas": "bun run scripts/codegen-schemas.ts",
"codegen:chains": "bun run scripts/codegen-chains.ts",
"codegen": "bun run codegen:schemas && bun run codegen:chains",
"test": "vitest --run",
"prepare": "husky install"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this deleted?

"tokenType": "canonical",
"deploySalt": "0x",
"iconUrls": {
"svg": "https://raw.githubusercontent.com/axelarnetwork/axelar-configs/images/tokens/mvx.svg"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was a typo in our scripts (which we'll fix). in the meantime, can you change this to https://raw.githubusercontent.com/axelarnetwork/axelar-configs/main/images/tokens/mvx.svg?

@canhtrinh canhtrinh mentioned this pull request Feb 16, 2024
@canhtrinh
Copy link
Collaborator

replacing with this PR: #23

@canhtrinh canhtrinh closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants