Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add --wasm-dir flag to start command #2111

Merged
merged 15 commits into from
Feb 28, 2024
Merged

Conversation

jcs47
Copy link
Contributor

@jcs47 jcs47 commented Feb 27, 2024

Description

Closes AXE-3260

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@jcs47 jcs47 requested a review from a team as a code owner February 27, 2024 02:21
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 47.92%. Comparing base (4a0d1d7) to head (aa811d4).

Files Patch % Lines
cmd/axelard/cmd/root.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2111      +/-   ##
==========================================
- Coverage   47.94%   47.92%   -0.02%     
==========================================
  Files         263      263              
  Lines       15883    15890       +7     
==========================================
+ Hits         7615     7616       +1     
- Misses       7678     7684       +6     
  Partials      590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jcs47 and others added 3 commits February 27, 2024 19:01
Co-authored-by: Milap Sheth <milap@axelar.network>
@jcs47 jcs47 added backport needed next release Required for the next release labels Feb 28, 2024
@cgorenflo cgorenflo enabled auto-merge (squash) February 28, 2024 19:51
@cgorenflo cgorenflo disabled auto-merge February 28, 2024 19:53
@cgorenflo cgorenflo merged commit a30eae9 into main Feb 28, 2024
9 of 10 checks passed
@cgorenflo cgorenflo deleted the feat/wasmdir_flag branch February 28, 2024 19:53
milapsheth added a commit that referenced this pull request Mar 1, 2024
…d ibc query (#2119)

* fix!: override wasm default param after initialization (#2105)

* feat(cli): add `--wasm-dir` flag to start command (#2111)

* fix(app): register wasm snapshot extension for state-sync (#2114)

* fix(app): register wasm snapshot extension for state-sync

* feature gate extension registration

* move to a separate function

* rename method

* fix(wasm): migrate wasm cache dir to the new path (#2115)

* add --wasm-dir flag to start command

* use /Users/joaosousa env var

* docs

* programatically determine the default value for the wasm dir

* addendum

* addendum

* fix

* edit flag description

Co-authored-by: Milap Sheth <milap@axelar.network>

* fix

* simplification

* fix(wasm): migrate wasm cache dir to the new path

* convert to abs path

* assume path is already expanded and move check earlier

* dep update

* go mod tidy

* use wasm path

---------

Co-authored-by: João Sousa <joaosousa@Joaos-MBP.home>
Co-authored-by: jcs47 <11947034+jcs47@users.noreply.github.com>

* feat(axelarnet): add queries to retrieve cosmos chains, ibc path (#2116)

* feat(axelarnet): add queries to retrieve cosmos chains, ibc path

* register cli cmds and add tests

* docs

* dep update

* remove chains query

* lint

* revert config change

---------

Co-authored-by: haiyizxx <haiyi@axelar.network>
Co-authored-by: jcs47 <11947034+jcs47@users.noreply.github.com>
Co-authored-by: João Sousa <joaosousa@Joaos-MBP.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needed next release Required for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants