-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add --wasm-dir
flag to start command
#2111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
- Coverage 47.94% 47.92% -0.02%
==========================================
Files 263 263
Lines 15883 15890 +7
==========================================
+ Hits 7615 7616 +1
- Misses 7678 7684 +6
Partials 590 590 ☔ View full report in Codecov by Sentry. |
milapsheth
reviewed
Feb 27, 2024
milapsheth
approved these changes
Feb 27, 2024
milapsheth
reviewed
Feb 27, 2024
milapsheth
reviewed
Feb 27, 2024
milapsheth
reviewed
Feb 27, 2024
Co-authored-by: Milap Sheth <milap@axelar.network>
milapsheth
approved these changes
Feb 27, 2024
cgorenflo
reviewed
Feb 27, 2024
cgorenflo
reviewed
Feb 27, 2024
haiyizxx
reviewed
Feb 28, 2024
haiyizxx
approved these changes
Feb 28, 2024
cgorenflo
approved these changes
Feb 28, 2024
milapsheth
pushed a commit
that referenced
this pull request
Mar 1, 2024
6 tasks
milapsheth
added a commit
that referenced
this pull request
Mar 1, 2024
…d ibc query (#2119) * fix!: override wasm default param after initialization (#2105) * feat(cli): add `--wasm-dir` flag to start command (#2111) * fix(app): register wasm snapshot extension for state-sync (#2114) * fix(app): register wasm snapshot extension for state-sync * feature gate extension registration * move to a separate function * rename method * fix(wasm): migrate wasm cache dir to the new path (#2115) * add --wasm-dir flag to start command * use /Users/joaosousa env var * docs * programatically determine the default value for the wasm dir * addendum * addendum * fix * edit flag description Co-authored-by: Milap Sheth <milap@axelar.network> * fix * simplification * fix(wasm): migrate wasm cache dir to the new path * convert to abs path * assume path is already expanded and move check earlier * dep update * go mod tidy * use wasm path --------- Co-authored-by: João Sousa <joaosousa@Joaos-MBP.home> Co-authored-by: jcs47 <11947034+jcs47@users.noreply.github.com> * feat(axelarnet): add queries to retrieve cosmos chains, ibc path (#2116) * feat(axelarnet): add queries to retrieve cosmos chains, ibc path * register cli cmds and add tests * docs * dep update * remove chains query * lint * revert config change --------- Co-authored-by: haiyizxx <haiyi@axelar.network> Co-authored-by: jcs47 <11947034+jcs47@users.noreply.github.com> Co-authored-by: João Sousa <joaosousa@Joaos-MBP.home>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes AXE-3260
Todos
Steps to Test
Expected Behaviour
Other Notes