feat: add core binary upload to cloudflare r2 bucket #2126
Merged
+74
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maancham
changed the title
maancham
changed the title
kalidax
reviewed
Mar 22, 2024
talalashraf
reviewed
Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2126 +/- ##
==========================================
+ Coverage 47.99% 48.01% +0.02%
==========================================
Files 263 263
Lines 15909 15909
==========================================
+ Hits 7635 7639 +4
+ Misses 7684 7680 -4
Partials 590 590 ☔ View full report in Codecov by Sentry. |
cgorenflo
reviewed
Mar 25, 2024
cgorenflo
approved these changes
Mar 25, 2024
milapsheth
reviewed
Mar 25, 2024
milapsheth
approved these changes
Mar 26, 2024
Co-authored-by: Milap Sheth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AXE-3426
Todos
Steps to Test
Expected Behaviour
Other Notes